Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Details View: Hide featured image if no image is applied #51508

Closed
richtabor opened this issue Jun 14, 2023 · 2 comments · Fixed by #51649
Closed

Page Details View: Hide featured image if no image is applied #51508

richtabor opened this issue Jun 14, 2023 · 2 comments · Fixed by #51649
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@richtabor
Copy link
Member

As the Page Details view is currently not editable, I propose we don't render a "No featured image" indicator. Instead, only render the featured image if there is one present. If this was a DropZone (performing just like the other featured image uploader) then I think it'd be fine to keep. cc @WordPress/gutenberg-design

CleanShot 2023-06-14 at 15 55 02
@richtabor richtabor added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Jun 14, 2023
@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 14, 2023

I went through the call for testing today and tested Gutenberg version 16.0.
I really enjoy seeing the information in the left sidebar as you show above, but I really missed being able to edit the information as we do in the right settings sidebar in a post/page.
It would be better to focus on adding functionality to this left sidebar area to give a consistent functionality that is similar to the right sidebar settings area.

@jameskoster
Copy link
Contributor

It's still not 100% clear exactly which details will be editable here. If that picture was clearer I would agree with you @paaljoachim. But for now, I think hiding makes sense when no featured image is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants