Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dynamic path in Navigations screen in Browse Mode #51561

Closed
getdave opened this issue Jun 16, 2023 · 0 comments · Fixed by #51565
Closed

Avoid dynamic path in Navigations screen in Browse Mode #51561

getdave opened this issue Jun 16, 2023 · 0 comments · Fixed by #51565
Assignees
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Jun 16, 2023

Currently we dynamically alter the path of "Navigation" on the main Browse Mode listing screen depending on whether there are multiple menus (go to Navigation listing route) or just one (go directly to single Navigation route).

Unfortunately this exposes the need to replicate that logic anytime external code needs to route to "Navigation".

Instead let's remove the routing and instead make the Navigation Listing route handle the dynamic part. That way the Editor can simply route to /navigation and it will "just work".


I'm not sure it's wise to do this (change the path depending on the number of menus). This creates an issue because now the "parent" of the navigation is "hidden". so for instance if you go to "navigation" and you click "back" you don't end up in the root place.

I wonder if the best solution is to instead of doing this, change the behavior within the /navigation screen to actually render the menu directly when there's one.

Originally posted by @youknowriad in #50840 (comment)

@getdave getdave changed the title Avoid dynamic path in Navigations screen Avoid dynamic path in Navigations screen in Browse Mode Jun 16, 2023
@getdave getdave self-assigned this Jun 16, 2023
@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a labels Jun 16, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 16, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
2 participants