Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkControl: Add a state to the drawer button #51653

Closed
t-hamano opened this issue Jun 19, 2023 · 1 comment
Closed

LinkControl: Add a state to the drawer button #51653

t-hamano opened this issue Jun 19, 2023 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels.

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

The LinkControl component toggles the settings panel via a drawer button.

hide_before

Personally, it is difficult to tell if a panel is open or not because the drawer button only changes color when the panel is opened.

show_before

What is your proposed solution?

How about adding a pressed state, similar to the opening and closing of the block sidebar and the document overview panel, or custom value entry in the block sidebar?

show_after_1

Make the icon smaller

show_after_2

I think that it would be better if the tooltip labels were also changed according to the state.

show_after_3

@t-hamano t-hamano added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jun 19, 2023
@t-hamano
Copy link
Contributor Author

I am closing this issue because I have learned that the UI has been changed by #51712 and the drawer is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

1 participant