Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Palette: Consider adding keyword support for searching #51742

Open
richtabor opened this issue Jun 21, 2023 · 5 comments
Open

Command Palette: Consider adding keyword support for searching #51742

richtabor opened this issue Jun 21, 2023 · 5 comments
Labels
[Package] Commands /packages/commands [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

I'd expect that when searching for template I would see all the templates I have on my site, so that I may quickly navigate to a template even if I'm unsure of its name. Perhaps adding keyword support will help surface relative commands.

I would expect these keyword matched commands to show up lower in priority to search matching via command titles though. For example, the existing "Open templates" command would appear higher in the results, above "Index" (which would have a keyword of "template").

@richtabor richtabor added the [Package] Commands /packages/commands label Jun 21, 2023
@annezazu annezazu changed the title Wayfinder: Consider adding keyword support for searching Command Palette: Consider adding keyword support for searching Jun 29, 2023
@annezazu
Copy link
Contributor

annezazu commented Jun 29, 2023

Came here to report the same thing as I searched "page template" only to find no results. However, if you just search for "page", you're met with many and need to recognize the icon for Page Template:

Screen Shot 2023-06-29 at 11 58 53 AM

@richtabor
Copy link
Member Author

Also related, adding additional context to these commands: #51505

@annezazu annezazu added the [Type] Enhancement A suggestion for improvement. label Jul 4, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 3, 2023
@KevinBatdorf
Copy link
Contributor

Searchable keywords or some other hidden search terms would be very useful.

For example, I was adding a simple math command (repo) that detects when the user enters a valid expression.

screenshot-1

Since the search only filters the label, it means I need to add the expression in the label

label: `${search} = ${output}`,

Ideally:

label: `= ${output}`,
keywords: [search]

I see it was moved to the TODO already but how does that work? I can pick this up if it's OK and not already being worked on.

@annezazu
Copy link
Contributor

annezazu commented Aug 15, 2023

This came up in the twenty fifth call for testing for the FSE Outreach Program:

The command palette ist not satisfying for me. It works , but for me the problem are the keywords. I could not find > top toolbar or list view. As a normal user i would expect a keyword like – list view – should open the list view, or keyword – top toolbar – , should open top toolbar, that does not work for me. It is try and error, like, i try it with – T – or – S – or something like that and i am looking what it shows me 🙂

And once more:

I found the autosuggest/listings to be varied in their accuracy. Some of them didn’t make much sense in their order compared to the actual search query: https://snipboard.io/jnSqNX.jpg

@talldan
Copy link
Contributor

talldan commented Oct 17, 2023

It might also be good to have synonyms for verbs (e.g. add, create, make). So if you type "Create post", it'll still show "Add new post" in the results.

@talldan talldan removed this from Patterns Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Commands /packages/commands [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants