Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contrast of site editor navigation current state color #51942

Closed
richtabor opened this issue Jun 26, 2023 · 3 comments
Closed

Improve contrast of site editor navigation current state color #51942

richtabor opened this issue Jun 26, 2023 · 3 comments
Assignees
@jameskoster
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@richtabor
Copy link
Member

Proposing that the .edit-site-sidebar-navigation-item.components-item[aria-current] is changed to white.

Before:
CleanShot 2023-06-26 at 16 45 43

After:
CleanShot 2023-06-26 at 16 46 05
@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 26, 2023
@richtabor richtabor added this to Polish Jun 26, 2023
@richtabor richtabor moved this to Needs development in Polish Jun 26, 2023
@jasmussen
Copy link
Contributor

Should be white text, yes, could this be a recent regression from #51856 @jameskoster?

@jameskoster
Copy link
Contributor

Yes looks like it. I'll open a PR shortly.

@jameskoster
Copy link
Contributor

Closed via #51965.

@priethor priethor removed the Needs Design Feedback Needs general design feedback. label Jul 4, 2023
@priethor priethor moved this from Needs development to Done in Polish Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskoster jameskoster

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
Polish
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jameskoster @jasmussen @richtabor @priethor