Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor > Styles tab: Link directly with no style variations #52158

Closed
jasmussen opened this issue Jun 30, 2023 · 2 comments
Closed

Site Editor > Styles tab: Link directly with no style variations #52158

jasmussen opened this issue Jun 30, 2023 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

The styles section is important to surface an entry point into editing global styles. For 6.3, however, the styles section will not come into full fruition, and #50924 even details how the prominence of style variations is not necessarily ideal.

So as to keep the value of surfacing the style editors, for 6.3 we'll keep the style variations. One bug we need to fix, however, is to ensure that if a theme doesn't have any style variations, we skip the drilldown entirely and have the top level "Styles" section link directly to the global styles editor. This:

Screenshot of the main site editor showing a Styles section
  • If there are style variations, the "Styles" link here should navigate to the existing detail page showing style variations
  • If there are no style variations, the same link should go directly to the Edit View with the global styles panel open (same as clicking the edit button in the detail page)
@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 30, 2023
@ntsekouras
Copy link
Contributor

@jasmussen if I get the description right, is what we already have in trunk with this PR, right?

@jasmussen
Copy link
Contributor Author

jasmussen commented Jun 30, 2023

Oh you're right, this behavior is already in trunk. Here's what happens if you have style variations:

style variations

But when you have no style variations, the detail page is skipped:

no style variations

In other words, you're right, this issue is already fixed.

Edit: I misunderstood initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants