Site Editor: Incorrect headings hierarch in the 'Manage all' screens #52254
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Edit Site
/packages/edit-site
[Type] Bug
An existing feature does not function as intended
[Type] Regression
Related to a regression in the latest release
Description
Note: In the following screenshots, I'm using the HeadingsMap browser extension (available for Chrome and Firefox) to visually illustrate the headings in the page.
In 'Manage all templates', 'Manage all template parts', and possibly other 'manage all' screens, the headings hierarchy is incorrect and skips a few levels. A correct headings hierarchy is of fundamental importance for screen rearer users to efficiently navigate the content.
Edit: Please note there are also two H1 headings, which is incorrect.
I seem to recall the hierarchy was already fixed in a PR a while ago so I'm going to mark this issue as a regression.
On a side note: it would be great to re-focus all designers and developers attention to always check for a correct headings hierarchy. It's such a simple thing to implement but in the history of this project there have been several cases where new features have been shipped with a broken headings structure. @mtias I'd greatly appreciate any suggestions on the best way to train developers on this and make sure everybody is always focused on using headings correctly 🙏
See also #52253
This is basic semantics / accessibility / HTML. It would be great to just not use heading levels randomly.
ScreenshotL All templates:
ScreenshotL All template parts:
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: