Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes: Unintended behavior in gallery image caption text #52383

Closed
t-hamano opened this issue Jul 6, 2023 · 5 comments · Fixed by #52682
Closed

Footnotes: Unintended behavior in gallery image caption text #52383

t-hamano opened this issue Jul 6, 2023 · 5 comments · Fixed by #52682
Labels
[Block] Footnotes Affects the Footnotes Block [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jul 6, 2023

Description

In the caption text of the image block in the gallery block, using the footnotes format inserts an unintended footnotes block. The footnotes block is generated, but nothing can be entered. This problem does not seem to occur with caption text in the gallery itself or in image blocks that are not in the gallery.

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

916c9ec02ceb7cd6f9a9ff7cd812166a.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Footnotes Affects the Footnotes Block labels Jul 6, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Jul 6, 2023

This is probably a duplicate of #52084.

@annezazu
Copy link
Contributor

annezazu commented Jul 6, 2023

Came here to connect the same thing :) Is anyone able to say for certain? For now, will add to 6.3 board to be safe.

@t-hamano
Copy link
Contributor Author

I have learned that #52084 has been closed, but the problem with this issue has not yet been resolved.

  • ✅ Text in a paragraph block within a Quote block can be correctly anchored.
  • ✅ Citation text within a Quote block can also be correctly anchored.
  • ❌ Caption text in an image block within a gallery block cannot be anchored correctly.
796560699b9ab927660a1630da4336ab.mp4

@bph
Copy link
Contributor

bph commented Jul 10, 2023

#52241 fixed for the Image block caption and the Gallery caption

What is still not working is the footnote for single image caption that belongs to a gallery.
If there are already footnotes on the page the county is off, and it doesn't add footnotes rather seems to intend to replace.

footnotes.in.gallery.mp4

If there is only the gallery in place, and you create new footnotes, it doesn't add a footnotes block to the canvas. It seems to be adding it to the caption directly.

Footnotes-in-gallery-2.mp4

@bph
Copy link
Contributor

bph commented Jul 17, 2023

Needs retesting when #52682 is merged.

@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.3.x Editor Tasks Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants