Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Make createNavigation and convertClassic part of Core Data #52596

Open
scruffian opened this issue Jul 13, 2023 · 0 comments
Open
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality

Comments

@scruffian
Copy link
Contributor

scruffian commented Jul 13, 2023

Raised in #52573:

What I don't like this the way we're having to pass in the createNavigation handler from another hook.

What this all points to is that the following should be part of Core Data (or #52134):

createNavigation
convertClassic

By moving these to global state we can safety make calls and know that the same resolution state will be applicable to all >instances. This will avoid future bugs and avoid us playing callback tennis across various hooks.

As these are Core-like actions I think this is more than acceptable.

@scruffian scruffian added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

No branches or pull requests

1 participant