Site Editor: 'Delete page' button should be 'Move to trash'

[afercia]

Description

In the Site Editor > Pages > any page, clicking the 'Actions' ellipsis menu reveals a dropdown menu with a 'Delete' button.

Clicking this button opens a confirm dialog with the text:

Are you sure you want to delete this page?

followed by two buttons: Cancel and Delete.

Everything in the UI uses the term 'delete'. As a user, I'd think the page is going to be permanently deleted.

Instead, the page gets moved to the Trash. This is a good thing and it's how WordPress always worked. However, the UI is just wrong as it hints to a delete action, while the actual action is moving to trash.

• The text of the button in the dropdown menu should be 'Move to trash' instead of 'Delete'.
• The confirm dialog is redundant. In WordPress, the 'move to trash' action never showed a confirm dialog as it is not a destructive action. Items can be restored from the Trash at any time.

I'm going to add also the Accessibility label because any UI control should always clearly identify the associated action.

Step-by-step reproduction instructions

• Go to Site Editor > Pages > any page
• In the navigator panel, click the 'Actions ellipsis button, then click 'Delete'.
• A modal dialog opens, asking confirmation. Click Delete.
• The page disappears and the editor navigator panel goes back to the 'Pages' list.
• Go to the WP admin > Pages > Trash at /wp-admin/edit.php?post_status=trash&post_type=page
• Observe the 'deleted' page isn't actually deleted. It's there in the Trash.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[afercia]

More wording needs to be changed, including the snackbar notice: