-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site editor: Navigating regions via keyboard shortcuts gets stuck on a region #52920
Comments
Note: when testing with Chrome and the browser dev tools panel is open, the panel steals focus from the page, not sure why. Best way to test with dev tools open, use the alternative shortcurs:
|
Regressed in #51956 Turns out that while the intent was good (fix the routing issues on mobile), the change makes When hiding, removing from the DOM, or (such as in this case) making on of these regions These regions need to:
in some case, for example the Settings region or the Save panel region, when the sidebar is not visible we are rendering at least one button within the region. The button is visually hidden but can be revealed via keyboard navigation and opens the related sidebar. This matches the users expectations. In fact, when using an ARIA role region with an aria-label on a certain element, that element becomes an ARIA landmark. Landmarks are a sort of 'contract' with the user. WHen landing on a page, ladnmarks inform users the page contains {n} main regions. At any moment, users expect to be able to find and nvigate these regions. Hiding and making one of the regions inert breaks the contract with the user. Quoting from the PR that introduced this regression #51956 (emphasis mine):
Stopping user interaction on an ARIA landmark that is also an editor NavigableRegion seems less than ideal.
|
@jeryj could you perhaps take a look here? |
Description
It appears that in the Site editor when navigating regions via keyboard shortcuts, at some point you get stuck on a region. This is a serious regression in a feature that greatly helps all keyboard users to use the editor efficiently.
As a side note: If I remember correctly there are a few E2E tests in place for the navigate regions feature but these are only for the Post editor. It appears it would be greatly beneficial to add tests for this feature also for the Site editor.
Reminder for testing: The keyboard shortcuts varies depending on the operating system. You can always check what the available keyboard shortcuts are in the editor > Options > Keyboard shortcuts.
On macOS:
Navigate to the next part of the editor.
Navigate to the previous part of the editor.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: