Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern editing (Manage all my patterns): Sync status overlaps for some languages #52960

Closed
carolinan opened this issue Jul 26, 2023 · 8 comments · Fixed by #53243
Closed

Pattern editing (Manage all my patterns): Sync status overlaps for some languages #52960

carolinan opened this issue Jul 26, 2023 · 8 comments · Fixed by #53243
Assignees
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

When you edit a user created pattern, the sync status in the pattern sidebar overlaps for some languages.

Step-by-step reproduction instructions

First, create a pattern.
Go to Site Editor > Patterns > Manage all my patterns.
In the admin interface select the pattern to edit.
In the editor, open the pattern sidebar.

Note that Site Editor > Patterns > My Patterns > Edit any pattern does not have the synced status in the sidebar.

Screenshots, screen recording, code snippet

English:
No overlap

Swedish translation:
Text overlaps

German translation:
Text overlaps

Environment info

Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended labels Jul 26, 2023
@carolinan
Copy link
Contributor Author

Related: #51451

@glendaviesnz glendaviesnz added the Needs Design Feedback Needs general design feedback. label Jul 26, 2023
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jul 26, 2023

It looks like this is a problem for the whole summary panel layout as the sync status just copies the flex layout of the existing params:
Screenshot 2023-07-27 at 10 42 40 AM

Have flagged it as needing design feedback as it would be good to look for a solution that works for this whole panel rather than just fixing the sync status.

@annezazu
Copy link
Contributor

Adding to 6.3 in case we can iterate it time and, if not, to have it on the radar for point releases cc @WordPress/gutenberg-design

@jameskoster
Copy link
Contributor

Agree the whole Summary panel could use some design love.

In the short term, could we use word-break to account for extra-long words like this? It's not perfect by a long stretch, but probably preferable to the overlapping label/value.

@ndiego
Copy link
Member

ndiego commented Aug 1, 2023

In the short term, could we use word-break to account for extra-long words like this? It's not perfect by a long stretch, but probably preferable to the overlapping label/value.

@jameskoster think we can get this in for 6.3, or will we need to punt this to 6.3.x?

@t-hamano
Copy link
Contributor

t-hamano commented Aug 1, 2023

I too would prefer to use word-break for now. There are approaches like #52249 that wrap columns, but it seems unnatural that only certain items are wrapped.

It would look like this.

German:

german

Swedish:

swedish

@jasmussen
Copy link
Contributor

☝️ I think that can work, but can we top-align instead of middle align? I.e. note how the first line for each row aligns across here:

Screenshot 2023-08-01 at 17 48 32

@t-hamano
Copy link
Contributor

t-hamano commented Aug 1, 2023

but can we top-align instead of middle align?

I think this is a good idea; like the URL row, this row also has a unique class name (.edit-post-sync-status), so applying the style should not be difficult.

I would like to submit a PR immediately if I may, but since the last RC release party has just started, it might be a good idea to punt to 6.3.x.

@t-hamano t-hamano self-assigned this Aug 1, 2023
@t-hamano t-hamano moved this from ❓ Triage to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Aug 1, 2023
@bph bph moved this from 🏗️ In Progress to 🐛 Punted to 6.3.1 in WordPress 6.3.x Editor Tasks Aug 1, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 1, 2023
@github-project-automation github-project-automation bot moved this from 🐛 Punted to 6.3.1 to ✅ Done in WordPress 6.3.x Editor Tasks Aug 3, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 3, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to Done in Patterns Aug 3, 2023
@aaronrobertshaw aaronrobertshaw moved this from Done to Todo in Patterns Aug 3, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to Done in Patterns Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants