Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: previewing a pattern which contains a Query disables the Site Browser back button #53025

Closed
jordesign opened this issue Jul 27, 2023 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@jordesign
Copy link
Contributor

Description

When previewing patterns - previewing a category which contains patterns that use a Query within them seems to break the Site Browser's 'Back button.

Additionally - there is a lot of flashing/glitching when loading the patterns that contain queries.


I found this to be true for categories containing the following types of patterns:

  • A pattern from the theme which contained the Comments block.
comments_pattern_theme.mov
  • A custom pattern which contained the Comments block.
comments_pattern_custom.mov
  • A custom pattern which contained a Query Loop
patterns_query.mov

Step-by-step reproduction instructions

  1. Open the Site Editor and go to the Patterns section
  2. Preview a pattern category which contains a pattern using a query within it (for example 'general' in TT2).
  3. Try and use the 'back' chevron to the left of the 'Patterns' title.

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.3 RC2
No plugins
TT3

Please confirm that you have searched existing issues in the repo.

No

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 27, 2023
@t-hamano
Copy link
Contributor

I think this issue has been resolved in #52964 and a backport label has been given, but it does not appear to have been backported to the latest RC version yet. It would be a good idea to test it again in the next RC3 release.

@tellthemachines
Copy link
Contributor

I can no longer reproduce this in Gutenberg trunk; closing as fixed by #52964, which will be added to 6.3 RC3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

3 participants