Update theme.json schema to mark text as an invalid variable name

[hanneslsm]

When I am adding the following color to my theme.json it overwrites all paragraphs where a custom text color is set.
This is just a coincidence that it generates the .has-text-color which is also used as a class, right?

  "settings": {
    "color": {
         "palette": [
                {
                  "color": "red",
                  "name": "Text",
                  "slug": "text"
                }
…

[hanneslsm]

Okay, I was able to reproduce this also with TT3.
My assumption from above was right.

Who from the documentation team could be pinged to add to the handbook that a variable with the slug "text" cannot be used?

[hanneslsm]

Don't know if it's possible, but maybe it could also be added to the Schema as an invalid variable?

[annezazu]

Do you mind opening an issue here for the docs team? https://github.com/WordPress/Documentation-Issue-Tracker/issues Someone can follow up there :)

[annezazu]

I'm going to close this out for now though but let me know if I'm missing something or it needs to be re-opened.

[hanneslsm]

Sure, Iw ill open an issue for the docs team.
However, if the Schema could also be changed, that would be great - so maybe reopening the issue for that? :)

[annezazu]

@ryanwelcher is this something you could help with since you implemented the schema from what I can remember?

[t-hamano]

I think two approaches are valid for this problem.

• In the slug property of theme.json, add a note to the description property that text/background, etc. cannot be used because they are used in the core.
• Show a warning message via the _doing_it_wrong() function if an unauthorized slug is defined.
  Example: Clarify error message if duotone color values is incorrect #51397