Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles in Theme.json: Add support for elements/interactive states and custom CSS #53186

Open
scruffian opened this issue Jul 31, 2023 · 1 comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

When block styles are defined in theme json, it's not possible to control:

  • elements
  • hover /active/ focus
  • custom css.

What is your proposed solution?

styles > blocks > block name > variations > variation name should support the same things as blocks:

  • elements
  • hover /active/ focus
  • custom css.
@scruffian scruffian added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jul 31, 2023
@carolinan
Copy link
Contributor

Adding custom CSS was explored here,
#49396 but was made difficult:

  1. Because of how the "default" block style can be any registered block style variation. Please read the comments here:
    Add custom CSS support to elements and block style variations #49396 (review)

  2. Lack of space and design for the controls in the Styles sidebar in the Site Editor. Both for elements and block styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants