Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link suggestions should indicate expected result of UX spinner #5327

Closed
roryashfordbentley opened this issue Mar 1, 2018 · 8 comments
Closed
Labels
[Status] Needs More Info Follow-up required in order to be actionable.

Comments

@roryashfordbentley
Copy link

roryashfordbentley commented Mar 1, 2018

Issue Overview

When you highlight some text and click the link button it says 'Paste URL or type'. To me this implies that typing a page title for example would find and link to that page. This is further emphasised by the little progress spinner that appears after you type a letter.

This same behaviour happens with the button block.

Steps to Reproduce (for bugs)

  1. Type some text
  2. Highlight the text and click the link icon
  3. Begin typing in an existing page name
  4. Visually it appears to be doing something but never brings up a list of matching pages or similar

Browser: Latest Version of Chrome.
PHP: 7.1.12

Expected Behavior

The UI and wording suggests that as you type there should be some user interface element that lets you select from a page, post or custom post type.

Current Behavior

There is no way to actually link to a site page without manually copying and pasting the URL.

Screenshots / Video

giphy

@jeffpaul jeffpaul added [Type] Enhancement A suggestion for improvement. [Type] Copy Issues or PRs that need copy editing assistance labels Mar 8, 2018
@karmatosed karmatosed removed the [Type] Copy Issues or PRs that need copy editing assistance label Apr 12, 2018
@apintocr
Copy link

Exactly the same issue here.

@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Apr 27, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Jun 4, 2018
@danielbachhuber danielbachhuber changed the title Link auto-complete bug Link suggestions should indicate expected result of UX spinner Jun 4, 2018
@danielbachhuber danielbachhuber added the Needs Design Feedback Needs general design feedback. label Jun 4, 2018
@danielbachhuber
Copy link
Member

Flagging Needs Design Feedback to get direction on what this UX should be.

@karmatosed
Copy link
Member

karmatosed commented Jun 9, 2018

I am not sure this needs feedback as in the latest version you get a list of pages come up so I would like to see why they are not for you.

2018-06-09 at 17 45
]

Are you using the latest version and confirm you are still using Chrome, the above was taken in Chrome.

@karmatosed karmatosed added [Status] Needs More Info Follow-up required in order to be actionable. and removed Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended labels Jun 9, 2018
@karmatosed karmatosed removed this from the WordPress 5.0 milestone Jun 9, 2018
@danielbachhuber
Copy link
Member

@karmatosed I think the UX case we need to solve for is when there aren't any matching results.

Notably, Pages don't yet show up in search results because it's blocked by #2084

@karmatosed
Copy link
Member

With pages in the classic editor and links you don't get any feedback. I think we have to avoid endless spinning but we are ok just not returning any pages also.

@danielbachhuber
Copy link
Member

With pages in the classic editor and links you don't get any feedback.

Good point.

@roikles @apintocr Will the solution for #2084 solve your problem?

@roryashfordbentley
Copy link
Author

@danielbachhuber That solution would be great!

@danielbachhuber
Copy link
Member

👍 Sounds good. We can track in #2084 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

5 participants