Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Focus outline of block items is missing in Blocks menu #53600

Open
t-hamano opened this issue Aug 12, 2023 · 2 comments · May be fixed by #53929
Open

Global Styles: Focus outline of block items is missing in Blocks menu #53600

t-hamano opened this issue Aug 12, 2023 · 2 comments · May be fixed by #53929
Assignees
@josephfusco
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

If you use the keyboard to focus on a block in the Blocks menu of the Global Styles menu, the outline will extend the full width of the content and the left and right sides of the outline will not be visible.

before

My sense is that you would expect the outline to look something like this:

after
@t-hamano t-hamano added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json CSS Styling Related to editor and front end styles, CSS-specific issues. labels Aug 12, 2023
@josephfusco
Copy link

josephfusco commented Aug 24, 2023 •
edited
Loading

I can confirm this is an issue.

This PR seems related: #51787

I should have a PR for this at some point today.

@josephfusco josephfusco linked a pull request Aug 24, 2023 that will close this issue
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 24, 2023
@josephfusco
Copy link

PR ready

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@skorasaurus skorasaurus added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephfusco josephfusco

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix focus outline of block items in blocks menu josephfusco/gutenberg
4 participants
@skorasaurus @jordesign @josephfusco @t-hamano