Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Revisions: return to Site Browser when style revisions were entered from that location. #53616

Closed
jordesign opened this issue Aug 14, 2023 · 4 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jordesign
Copy link
Contributor

What problem does this address?

When entering the Style Revisions from the Site Browser, and then closing them again, I expect to be returned to the Site Browser. Instead I find myself in the Index/Blog template in editing mode.

style_revision_back.mov

What is your proposed solution?

Is there a way to remember the entry point to Style Revisions and return to that state when closing/accepting revisions?

@jordesign jordesign added [Feature] Theme Style Variations Related to style variations provided by block themes [Feature] History History, undo, redo, revisions, autosave. [Type] Enhancement A suggestion for improvement. labels Aug 14, 2023
@annezazu
Copy link
Contributor

Hmm I'm torn about this as I could see it causing more confusion than clarity, particularly since this wouldn't happen any other time you explicitly click into the edit view (which is what's happening when you click on style revisions). It's not a good interaction to start going down since we're doing a lot to differentiate the two, offering a high level setup with Site View and a more detailed/robust setup with Edit View. Curious for @WordPress/gutenberg-design's thoughts.

@annezazu annezazu added the Needs Design Feedback Needs general design feedback. label Aug 15, 2023
@jasmussen
Copy link
Contributor

I go both ways on that one, the flow as suggested is definitely not ideal.

But I also think it touches on a larger issue with how Global Styles are currently taking you into the edit view, wheras arguably you could stay in site view the whole time. If that were to happen (@jameskoster I think there was an issue where you mocked this up) this issue would be addressed as part of that.

@jameskoster
Copy link
Contributor

Agreed. I see this as part of the 'Interface' improvements on the Global Styles roadmap (#41232).

@jordesign
Copy link
Contributor Author

If that's tracked elsewhere - then I'm happy with that. 😄 Happy for this to be closed and handled as part of the broader Global Styles work.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Theme Style Variations Related to style variations provided by block themes Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants