Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing "Create pattern" modal should not close the block options menu #53694

Closed
richtabor opened this issue Aug 15, 2023 · 0 comments · Fixed by #53707
Closed

Closing "Create pattern" modal should not close the block options menu #53694

richtabor opened this issue Aug 15, 2023 · 0 comments · Fixed by #53707
Assignees
@aaronrobertshaw
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

There's a small inconsistency between closing the "Lock/Unlock" modal vs. closing the "Create pattern" modal. I'd expect them both to work the same (as "Lock/Unlock" do now) where the block options menu is not also closed when closing the modal.

CleanShot.2023-08-15.at.14.03.35.mp4
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Aug 15, 2023
@richtabor richtabor added this to Polish Aug 15, 2023
@richtabor richtabor moved this to Needs development in Polish Aug 15, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 16, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to In Progress in Patterns Aug 16, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2023
@aaronrobertshaw aaronrobertshaw mentioned this issue Aug 16, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 16, 2023
@aaronrobertshaw aaronrobertshaw moved this from In Progress to Needs Review in Patterns Aug 16, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Patterns Aug 16, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Aug 16, 2023
@priethor priethor moved this from Needs development to Done in Polish Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
Polish
Status: Done
Patterns
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns: Prevent convert modal closing block options menu WordPress/gutenberg
3 participants
@richtabor @priethor @aaronrobertshaw