Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Top Toolbar 'Add New Template' missing for mobile #53927

Closed
colorful-tones opened this issue Aug 24, 2023 · 3 comments
Closed

Site Editor: Top Toolbar 'Add New Template' missing for mobile #53927

colorful-tones opened this issue Aug 24, 2023 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended

Comments

@colorful-tones
Copy link
Member

Description

There is no means to Add a New Template in the Site Editor for small screens. I discovered this while debugging #49772

Step-by-step reproduction instructions

  1. Launch the Site Editor by visiting Appearance > Editor
  2. Click 'Templates' to view available templates
  3. Note the missing + icon where you would click to 'Add New Template' on mobile, which should appear next to the top heading of 'Templates'

Screenshots, screen recording, code snippet

desktop mobile
Screenshot 2023-08-24 at 2 32 08 PM Screenshot 2023-08-24 at 2 32 21 PM

Environment info

  • WordPress 6.3 / TT3 theme
  • Gutenberg Trunk only activated
  • Any screensize under 400 (for what I tested) using Chrome Dev Tools and Toggle Device Toolbar

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@colorful-tones colorful-tones added Mobile Web Viewport sizes for mobile and tablet devices [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Aug 24, 2023
@colorful-tones
Copy link
Member Author

I believe the code where this is happening is:

const canCreate = ! isMobileViewport;
return (
<SidebarNavigationScreen
title={ __( 'Templates' ) }
description={ __(
'Express the layout of your site with templates'
) }
actions={
canCreate && (
<AddNewTemplate
templateType={ 'wp_template' }
toggleProps={ {
as: SidebarButton,
} }
/>

@t-hamano
Copy link
Contributor

I think this issue is related to #49769.

@colorful-tones
Copy link
Member Author

@t-hamano thanks for the duplicate note. I agree, but I made a note for Anne to update her original Issue notes, because there is nothing that references or notes that the Add a New Template button is missing. It is on the same screen that is being reported in Anne's Issue, but in a different spot and could easily be missed when that Issue is addressed. Once she updates with that note then I'll be sure to close this out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants