-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "justify" option from List block #540
Comments
Shouldn't alignment be removed entirely from this one? |
We were talking with @jasmussen that it may make sense to retain the left/right/center. But I'm not sure. What are your reasons for removing all of them? |
Aligning a list block feels odd, but maybe that's just me. :) Have no strong opinion. |
@jasmussen @annaephox any thoughts on this? |
In general I lean towards starting out opinionated and minimalist, and adding back as needed. I'm also leaning towards alignments, especially center alignment, not making any sense for lists. There's a use case for RTL languages that you brought up Matías, but I think we might want to mimic what the editor does currently. There's also #138. All of this leads me to lean towards wanting to remove alignments. However I'm not rigid on this. |
Let's start with no alignment then. It would be a nice example of a block that doesn't have attributes there. |
If the alignment is for float, not text, it makes sense to apply it to the block itself, not the list items. Someone might want to float each list item to make a menu, but that's more advanced. For text alignments, I can see people using it for the whole block, but I really don't like centered lists and don't want to encourage their use. They could use individual lines instead of a list and get the same thing(maybe, if the line-height was cooperative). The same for text aligning the list items (each one different or something). |
Yep, I'm thinking of this as a feature to build later in the year for the customization focus. #427 |
Not seeing in master, so closing! |
Core has removed this item from the formatting bar.
The text was updated successfully, but these errors were encountered: