Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure appropriate labels are provided for color/gradient picker controls #54055

Open
1 of 3 tasks
andrewhayward opened this issue Aug 30, 2023 · 3 comments
Open
1 of 3 tasks
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components

Comments

@andrewhayward
Copy link
Contributor

andrewhayward commented Aug 30, 2023

What problem does this address?

Changes introduced in #52255 make it a requirement for the CircularOptionPicker to have an aria-label/-labelledby prop provided, to make sure appropriate context is available for the control. The three consuming components (ColorPalette, DuotonePicker and GradientPicker) all hide this requirement behind a default value, and should transition away from optional ARIA props to requiring a label of some sort.

What is your proposed solution?

All of the higher-order controls that use these three foundational components should be updated to provide a more appropriate and relevant label for their context, passing either an aria-label or aria-labelledby prop.

Acceptance Criteria

  • Identify all of the controls that use ColorPalette, DuotonePicker and GradientPicker
  • Update them to provide context-appropriate labels with aria-label or aria-labelledby
  • Update ColorPalette, DuotonePicker and GradientPicker to require one of aria-label or aria-labelledby (see related conversation)
@ciampo ciampo moved this to Up next in Andrew's onboarding Aug 30, 2023
@bph bph added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Aug 30, 2023
@andrewhayward
Copy link
Contributor Author

andrewhayward commented Sep 4, 2023

@andrewhayward
Copy link
Contributor Author

andrewhayward commented Sep 4, 2023

Components that use <GradientPicker>:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components
Projects
None yet
Development

No branches or pull requests

2 participants