Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List View: Ensure consistent focus when closing the list view when no blocks are selected #54165

Closed
andrewserong opened this issue Sep 5, 2023 · 0 comments · Fixed by #54175
Closed

List View: Ensure consistent focus when closing the list view when no blocks are selected #54165

andrewserong opened this issue Sep 5, 2023 · 0 comments · Fixed by #54175
Assignees
@andrewserong
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@andrewserong
Copy link
Contributor

What problem does this address?

As raised during review of #48708, when no blocks are selected within the list view in the post and site editors, upon closing the list view, focus is not consistently placed anywhere and so it can go nowhere. This is most obvious when using the keyboard shortcut to open and close the list view. The keyboard shortcut for closing the list view is alt+shift+o on Windows, and control+option+o on Mac.

What is your proposed solution?

When closing the list view, if no blocks are selected, try directing focus to the list view toggle button in the top toolbar.
@andrewserong andrewserong added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels Sep 5, 2023
This was referenced Sep 5, 2023
Merged
Merged
@bph bph moved this to Triage in WordPress 6.4 Editor Tasks Sep 6, 2023
@bph bph moved this from Triage to Needs Dev / Todo in WordPress 6.4 Editor Tasks Sep 8, 2023
@bph bph mentioned this issue Sep 15, 2023
Open
@bph bph moved this from Needs Dev / Todo to In Progress in WordPress 6.4 Editor Tasks Sep 18, 2023
@andrewserong andrewserong self-assigned this Sep 18, 2023
@bph bph linked a pull request Sep 18, 2023 that will close this issue
List View: Try directing focus to the list view toggle button when closing the list view #54175
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in WordPress 6.4 Editor Tasks Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewserong andrewserong

Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
1 participant
@andrewserong