Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchControl to include size option #54501

Closed
jameskoster opened this issue Sep 15, 2023 · 2 comments · Fixed by #54548
Closed

Update SearchControl to include size option #54501

jameskoster opened this issue Sep 15, 2023 · 2 comments · Fixed by #54548
Assignees
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Search

It would be nice to update the SearchControl component so that it offers size options like InputControl and SelectControl.

Currently the search input is a static 48px tall. This is inconsistent with all inputs which are gravitating towards a 40px default (see #46741).

The designs for updated tables in the site editor (#53233) call for a smaller search input (32px) tall.

Ideally the sizes would be:

  • Default: 32px
  • Large: 40px

We might consider a small variant too, though there's no immediate need for it.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Sep 15, 2023
@ciampo
Copy link
Contributor

ciampo commented Sep 15, 2023

Ideally the sizes would be:

Default: 32px
Large: 40px

Shouldn't 40px be the default size, and 32px and small/compact size? That would align with the work we've been doing with all other control components.

@jameskoster
Copy link
Contributor Author

Sure, that works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
2 participants