Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing category descriptions from pattern flyouts #54874

Closed
richtabor opened this issue Sep 27, 2023 · 1 comment · Fixed by #54894
Closed

Consider removing category descriptions from pattern flyouts #54874

richtabor opened this issue Sep 27, 2023 · 1 comment · Fixed by #54894
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Are pattern category descriptions useful in the flyouts that contain the patterns? We don't have descriptions on all of them, and they also cause variance in the positioning of the patterns below (as some are two lines, others single). These descriptions are also quite weak/use different voicing.

CleanShot 2023-09-27 at 10 16 41 CleanShot 2023-09-27 at 10 16 23 CleanShot 2023-09-27 at 10 16 16 CleanShot 2023-09-27 at 10 16 09
@richtabor richtabor added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Sep 27, 2023
@richtabor richtabor changed the title Consider removing pattern category descriptions from pattern flyouts Consider removing category descriptions from pattern flyouts Sep 27, 2023
@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Sep 27, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 27, 2023
@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Sep 28, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Sep 28, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 28, 2023
@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Sep 28, 2023

While it might be premature, in case we wanted to get this enhancement into the 6.4 beta, I've spun up a quick PR removing the category description that can be played with in #54894.

If we are removing the category description in the editor's inspector, should we also remove the description from the site editor's pattern management page?

Screenshot 2023-09-28 at 10 58 15 am

@github-project-automation github-project-automation bot moved this from Todo to Done in Patterns Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants