Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: No blockGap unless you specify #54891

Closed
iamtakashi opened this issue Sep 27, 2023 · 3 comments · Fixed by #54992
Closed

Navigation Block: No blockGap unless you specify #54891

iamtakashi opened this issue Sep 27, 2023 · 3 comments · Fixed by #54992
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@iamtakashi
Copy link

Description

The elements in the Navigation block don't seem to have blockGap anymore.

Although a custom blockGap works as expected, it shouldn't be necessary.

If I deactivate Gutenberg (trunk) the gaps come back.

Step-by-step reproduction instructions

  1. Open the site editor.
  2. Use a Navigation block to build a navigation
  3. See the links in the block appear back-to-back without any gap.

Screenshots, screen recording, code snippet

Without Gutenberg plugin With Gutenberg plugin
localhost local_wp-admin_site-editor php (3) localhost local_wp-admin_site-editor php_canvas=edit

Environment info

WP 6.3.1
Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@bgardner
Copy link

Can confirm this is happening. Worth noting that (for me) this is only a Site Editor issue, and not a front end issue. See video.

Screen.Recording.2023-09-27.at.6.09.39.PM.mp4

@bgardner
Copy link

I am experiencing the issue with WP 6.4 Beta1, with or without Gutenberg active.

@Mamaduka Mamaduka added [Block] Navigation Affects the Navigation Block [Feature] Layout Layout block support, its UI controls, and style output. labels Sep 28, 2023
@bph bph moved this to Triage in WordPress 6.4 Editor Tasks Sep 28, 2023
@jordesign jordesign added the [Type] Regression Related to a regression in the latest release label Sep 28, 2023
@bph bph moved this from Triage to Needs Dev / Todo in WordPress 6.4 Editor Tasks Sep 30, 2023
@glendaviesnz
Copy link
Contributor

glendaviesnz commented Oct 2, 2023

It looks like this is a side-effect of #46752

There was a similar issue here, and have tried the fix PR for that, but it doesn't resolve this issue.

It looks like some of the global styles layout selectors break if not prepended with the editor styles wrapper class, but this may have just been masking an issue with the way the flex classes are applied on the nav block so we will look for a fix at the nav block level rather than adding back .editor-styles-wrapper to this style outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Layout Layout block support, its UI controls, and style output. [Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants