Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts: Switching style variations unchecks active fonts #54985

Open
Tracked by #60528
annezazu opened this issue Oct 2, 2023 · 4 comments
Open
Tracked by #60528

Fonts: Switching style variations unchecks active fonts #54985

annezazu opened this issue Oct 2, 2023 · 4 comments
Labels
[Feature] Font Library [Feature] Theme Style Variations Related to style variations provided by block themes [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Oct 2, 2023

Description

After uploading and activating a font, if you switch to a different style variation, the same uploaded font variations are de-selected, essentially removing the font from being selected and requiring you to re-activate each variant. cc @matiasbenedetto

Video

switching.style.variations.mov

Environment

  • MacOS
  • WordPress 6.4-beta1-56752
  • Gutenberg 16.7
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Oct 2, 2023
@annezazu annezazu moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Oct 2, 2023
@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Oct 4, 2023

Thanks for reporting this, but currently, this is the expected behavior.
When a user switches global styles, the theme.json of the style variant file is saved as the content of global styles post in the database. The active installed fonts are stored in global styles, so when the switch happens, the active fonts (as all the other elements stored in global styles) are replaced by the content of the style variation theme.json data. To change this behavior, we would need to change how the style variations work in a non-standard way. I think we can think more about this in the future, but for now, I think is not a priority in the refinements needed by the font library.

I'm removing the bug label.
@annezazu I suggest to remove it from the 6.4 board.

@matiasbenedetto matiasbenedetto removed the [Type] Bug An existing feature does not function as intended label Oct 4, 2023
@annezazu annezazu added the [Type] Enhancement A suggestion for improvement. label Oct 4, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Oct 4, 2023

Fantastic! Thank you. Removed and added the enhancement label.

@annezazu annezazu moved this to ❓ Triage in WordPress 6.5 Editor Tasks Jan 12, 2024
@colorful-tones colorful-tones added [Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Font Library labels Jan 23, 2024
@annezazu annezazu moved this from ❓ Triage to 🦵 Punted to 6.6 in WordPress 6.5 Editor Tasks Feb 8, 2024
@annezazu
Copy link
Contributor Author

annezazu commented Feb 8, 2024

After a review by core editor triage leads and core editor tech leads, this has been punted for consideration to 6.6. This doesn't mean it'll for sure make it into the 6.6 release to be clear!

@colorful-tones
Copy link
Member

Hi folks,
We are only one week away from the Beta 1 cut-off date for WordPress 6.6. This issue hasn’t seen any movement in a while, so we (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Theme Style Variations Related to style variations provided by block themes [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants