Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fonts: theme font family missing when editing individual blocks #55011

Closed
annezazu opened this issue Oct 3, 2023 · 2 comments · Fixed by #55219
Closed

Fonts: theme font family missing when editing individual blocks #55011

annezazu opened this issue Oct 3, 2023 · 2 comments · Fixed by #55219
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Oct 3, 2023

Using WP 6.4-beta1-56757 and GB 16.7, the theme provided fonts disappear post uploading a custom font. Here are steps to replicate:

  1. Select a block to edit
  2. Add the “Font Family”
  3. Open the dropdown, and verify all the theme fonts are there
  4. Open the Font Library modal
  5. Upload and install the new font
  6. Go back to edit a block
  7. Open the dropdown again, and verify the theme fonts disappear

Video displaying this:

missing.all.font.family.mov
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Oct 3, 2023
@annezazu annezazu moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Oct 3, 2023
@arthur791004
Copy link
Contributor

arthur791004 commented Oct 5, 2023 •
edited
Loading

The block settings only pick font families from one of the below in order from the global styles settings

  • custom
  • theme
  • default

But I cannot figure out why as I assume we can simply merge them 🤔

@arthur791004 arthur791004 mentioned this issue Oct 5, 2023
Merged
3 tasks
@annezazu annezazu moved this from Needs Dev / Todo to Punted to 6.5 in WordPress 6.4 Editor Tasks Oct 5, 2023
@arthur791004 arthur791004 mentioned this issue Oct 6, 2023
Closed
23 tasks
@matiasbenedetto matiasbenedetto mentioned this issue Oct 10, 2023
Merged
@matiasbenedetto
Copy link
Contributor

This was caused by a problem not specific to the font library but the global styles/settings. This PR should solve it: #55219

@github-project-automation github-project-automation bot moved this from Punted to 6.5 to Done in WordPress 6.4 Editor Tasks Oct 10, 2023
@t-hamano t-hamano mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use all the settings origins for a block that consumes paths with merge. WordPress/gutenberg
3 participants
@matiasbenedetto @arthur791004 @annezazu