Site Editor: creating a new page doesn't invoke pattern selection

[annezazu]

When using Twenty Twenty-Four and adding a new page in the Site Editor, despite having patterns registered for page creation, the starter pattern modal never appears causing you to enter an empty page, despite there being patterns registered for this creation process. This stands in contrast to when you create a new page using Pages > Add New Page.

cc @richtabor for flagging this and @aaronrobertshaw in case you can help :)

Visual

CleanShot.2023-10-05.at.17.22.47.mp4

[talldan]

I think the pattern selection modal was only ever implemented in the post/page editor. I'll have a look to see if I can port it to the site editor.

[talldan]

This is technically an enhancement btw, as it was a never implemented feature rather than a bug.

I'll look into what it takes to implement it, hopefully have a PR, and then we can decide what to do about it and 6.4.

[talldan]

#55117 is almost there. Just debugging an issue with there being no patterns in the block editor store when editing a new page via the site editor (wp.data.select( 'core/block-editor' ).getPatternsByBlockTypes( 'core/post-content' ); returns an empty array).

At the end of my day now so will pick it up on Monday.

[richtabor]

Thanks @talldan!

[annezazu]

Great to know! Removing from 6.4 in that case. Thank you for diving in.

[talldan]

I think I've managed to get it working here - Add starter patterns to site editor new page

However I haven't had time to update the PR description. That'll be a tomorrow task.