Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: add option to delete an individual variant #55176

Open
Tracked by #60528
annezazu opened this issue Oct 9, 2023 · 7 comments
Open
Tracked by #60528

Font Library: add option to delete an individual variant #55176

annezazu opened this issue Oct 9, 2023 · 7 comments
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Oct 9, 2023

Pulling from the FSE Outreach Program's Final Touches call for testing:

Still in the font library, would it be possible to have an option to delete certain font variants/weights? This case came up when adding Google Fonts where the font weights are downloaded individually and currently there’s no way to uninstall a specific weight. I understand that this problem could be circumvented by uploading a single file variable font (.ttf) instead. Unfortunately, this can only be done manually. IMO, it would be nice to have the Site Editor font library to be able to download single file variable fonts directly from Google.

Right now, there's not a way to fully remove a single variant beyond deactivating it.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Typography Font and typography-related issues and PRs labels Oct 9, 2023
@afercia afercia added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Jan 29, 2024
@afercia
Copy link
Contributor

afercia commented Jan 29, 2024

Raising this issue to bug, as the deletion process so far deletes all fonts even when the user intent is to delete only one or a few variants. I'm not sure what the purpose of the checkboxes for the variant is when deleting in the first place.

Checkboxes communicate user they can make a selection of variants and only delete the selected ones. Instead, regardless of the actual selection, all variants get deleted.

To reproduce:

  • Install a few variants of a Google font, for example 'Alexandria' 100, 200, 300, and 400.
  • Close the Fonts modal dialog an reopen it, just in case.
  • In the library tab, click the Alexandria font.
  • You are now in the font details 'sub view'. By default, the 4 variants will be all checked.
  • Uncheck all variants but Alexandria 200.
  • As the UI allows me to do that, as a user I understand I can uninstall variants selectively.
  • Click Delete. A confirm dialog opens.
  • Observe the confirm dialog text does say 'Are you sure you want to delete ... and all its variants and assets'. However, I'd argue users may miss this detail. Screenshot:

Screenshot 2024-01-29 at 14 26 05

  • Click Delete again in the confirm dialog.
  • The confirm dialog closes and the Font library refreshes.
  • Observe the Alexandria font has been completely uninstalled. All variants are now gone.

I'm not sure this is a good user experience. Actually, the user interface allows to perform an action that leads to an unexpected result. I'm not sure what the purpose of the checkboxes in the delete flow is.

@annezazu
Copy link
Contributor Author

@matiasbenedetto for consideration ^

@matiasbenedetto
Copy link
Contributor

Thanks for the ping.

Removing individual font faces was not part of the mockups. I think this needs some design feedback. Pinging @jasmussen for consideration.

@matiasbenedetto matiasbenedetto added the Needs Design Needs design efforts. label Jan 29, 2024
@jasmussen
Copy link
Contributor

Can we make the delete button contextual to the checkboxes?

Deleting Font Files

@skorasaurus
Copy link
Member

can confirm this is the case in Gutenberg 18.0.0; WP 6.5; and unfortunately, they are still listed even if you delete the font files through the command line (wherever the font files are stored) as reported in #58375

@akasunil
Copy link
Member

It has been implemented now. It possible to install/remove or activate/deactivate single font face now in latest trunk. I think we can close this issue.

Blog-Home-.-Template-.-gutenber-.-Editor-.-WordPress.2.webm

@annezazu
Copy link
Contributor Author

I'm afraid the problem remains with GB 18.8 and WP 6.6.1 RC1. In your case, you installed one variant so deleting allows you to just delete that option. If you install multiple variants of a single font family then try to delete only a few, the entire font is deleted. See below:

uninstall.single.variant.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants