Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Compatibility: handle caption shortcode #554

Closed
mtias opened this issue Apr 28, 2017 · 4 comments
Closed

Image Compatibility: handle caption shortcode #554

mtias opened this issue Apr 28, 2017 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Question Questions about the design or development of the editor. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
Feature Complete

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

The compat layer for the image block should be able to handle [caption].
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@mtias mtias added the [Type] Question Questions about the design or development of the editor. label May 17, 2017
@mtias mtias modified the milestones: Beta, Nice To Have, Beta Jun 15, 2017
@ellatrix
Copy link
Member

Do you mean it should be handled in the freeform block? Wouldn't it be better to just have the old editor exactly as the freeform block, just with a different design? See also #1256.

@mtias
Copy link
Member Author

mtias commented Aug 31, 2017

This was meant to allow a way to convert old images with captions into the new shape. I think @azaozz was thinking along these lines as well. We may want to focus on pasting first (from old WP content with shortcodes) as a way to convert, and then see fi we want to also offer an on demand mechanism for it.

@mtias
Copy link
Member Author

mtias commented Oct 19, 2017

@iseulde I think we can close this one as being handled by pasting.

@ellatrix
Copy link
Member

ellatrix commented Nov 1, 2017

Yep, done now in #2874.

@ellatrix ellatrix closed this as completed Nov 1, 2017
@InfiniteLove2020 InfiniteLove2020 mentioned this issue Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Question Questions about the design or development of the editor. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Feature Complete
Development

No branches or pull requests
3 participants
@mtias @jasmussen @ellatrix