Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Arrow keys to multi-select broken in opposite direction #5548

Closed
ellatrix opened this issue Mar 10, 2018 · 2 comments · Fixed by #6606
Closed

Shift+Arrow keys to multi-select broken in opposite direction #5548

ellatrix opened this issue Mar 10, 2018 · 2 comments · Fixed by #6606
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Milestone

Comments

@ellatrix
Copy link
Member

Issue Overview

When using Shift+Arrow keys to multi-select blocks, and then going back in the opposite direction, the selection is reset at the start block + block at the other side.

Steps to Reproduce (for bugs)

  1. Select a block.
  2. Use Shift+Arrow Down to trigger multi-selection. Select a few blocks.
  3. Use Shift+Arrow Up to to go in the opposite direction again, i.e. deselect the last select block and so on. Instead the selection is reset and the start block + the block above are multi-selected.

Expected Behavior

To de-select blocks one at a time.

Related Issues and/or PRs

#5513 (comment)

@ellatrix ellatrix added the [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... label Mar 10, 2018
@jasmussen
Copy link
Contributor

Not sure if this is the same issue or a different one. But there seems to be an additional issue with shift selecting. GIF:

shift select

Shift select across paragraphs works.

Setting the caret in the last text block and shift selecting downwards, selects until the end of the text in that block, as it should.

Setting the caret in the first block and shift selecting upwards, doesn't seem to select until the beginning of the text in that block, as would be expected.

It's a bit hard to explain — but is that related to this ticket? Or a separate issue?

@ellatrix
Copy link
Member Author

I think I see what you mean. Probably better to open a separate issue as this would be a separate fix. I'll see if I can look into it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants