-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles Revisions: revision history overview is difficult to access #55486
Comments
Thanks for creating this issue. Retaining "Reset to defaults" was a deliberate measure in #51318, which consolidated these buttons to remove a bit of clutter in styles actions bar. This is despite the "Default styles" entry at the end of the revisions list. The "Reset to defaults" in the drop down still provides quick access to reverting global styles changes, particularly where the revisions list is long and the "Default styles" revision is buried at the bottom of the list. Furthermore, there are plans to allow I think, however, there could be scope to use the idea in this issue and move the "Reset" button to a more prominent position in the revisions view itself. cc @jameskoster for thoughts |
I could go either way on this one to be honest. Given that resetting to defaults is a fairly infrequent action(?), and that similar links (e.g. posts) take you directly to the revisions UI (where you can reset to default), I could see this button opening the revisions panel rather than a dropdown. This change could make the revisions button a toggle too, which would probably work a bit better than the current experience—it's a bit strange how you can open the revisions dropdown when you're already in the Revisions panel. All that said, it would make resetting more arduous, particularly when there are multiple pages of revisions as Ramon pointed out. I'd be interested to hear other designers thoughts on this one cc @WordPress/gutenberg-design |
I think that's much too prominent. |
Regarding the reset button location, I suggested one approach in this comment. Another approach is to move only the reset button back to the ellipsis menu. And the revision button is a button that toggles the revision panel directly and does not display a popover. |
I closed #55620 pending further discussion. I believe others are thinking about this in a more holistic manner cc @apeatling |
Tracking more holistic changes here #55776 |
I think the following PR closes this issue, no? |
I also think this issue has been resolved by #56454, so I would like to close it. Revisions can be opened and closed in one click from the Global Styles panel, and we can still access the Reset Styles menu. d7e5b564bde51b25b269a0bab68b8635.mp4 |
Thanks for catching this one 👍 |
What problem does this address?
The revision history overview is difficult to access. The history is only accessible via an unnecessary intermediate step.
By clicking on the button this unnecessary overview appears:
... You then still have to click on "Revision history" to finally see the history:
What is your proposed solution?
By clicking on the button, the history overview should be displayed directly.
The text was updated successfully, but these errors were encountered: