Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data views]: When a filter changes the page should be reset to the first page #55756

Closed
ntsekouras opened this issue Nov 1, 2023 · 0 comments · Fixed by #55797
Closed

[Data views]: When a filter changes the page should be reset to the first page #55756

ntsekouras opened this issue Nov 1, 2023 · 0 comments · Fixed by #55797
Assignees
@oandregal
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ntsekouras
Copy link
Contributor

ntsekouras commented Nov 1, 2023 •
edited
Loading

We need a good way to reset the page of the data views component when any filter changes. This seems like it should be handled internally in data views as is the expected behavior. Right now we have some manual handling in some controls like Search, but we don't in the rest filters which just spread them and add some keys. --cc @oandregal

Related: #55100

Testing instructions

  1. Enable the data views experiment and go to pages list
  2. Select the second page
  3. Add an author filter
  4. Observe that the request fails
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 1, 2023
@oandregal oandregal mentioned this issue Nov 2, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oandregal oandregal

Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DataViews: reset pagination upon filter change WordPress/gutenberg
2 participants
@oandregal @ntsekouras