Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply global styles background color to InserterPreviewPanel #56460

Open
richtabor opened this issue Nov 23, 2023 · 2 comments
Open

Apply global styles background color to InserterPreviewPanel #56460

richtabor opened this issue Nov 23, 2023 · 2 comments
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

A tiny detail, but previews used in the InserterPreviewPanel would look nicer if the theme's global styles background color was used (if available) instead of a UI background color.

We use it in the CanvasLoader; it'd be nice to do the same in InserterPreviewPanel.

Before After
before after
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks labels Nov 23, 2023
@richtabor
Copy link
Member Author

Uncovered while optimizing for #56011.

@richtabor richtabor added this to Polish Nov 23, 2023
@richtabor richtabor moved this to Needs development in Polish Nov 23, 2023
@juanfra
Copy link
Member

juanfra commented Aug 20, 2024

I love these details. I just checked and It is working with the latest Gutenberg (19.0.0). It was probably resolved as part of some other ticket.

Screen.Recording.2024-08-20.at.10.47.26.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
Polish
Status: Needs development
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juanfra @richtabor