Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default block appender doesn't appear underneath nested blocks #5722

Closed
noisysocks opened this issue Mar 21, 2018 · 3 comments
Closed

Default block appender doesn't appear underneath nested blocks #5722

noisysocks opened this issue Mar 21, 2018 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

Issue Overview

When editing a column block, the default inserter does not appear underneath the last block in the column.

Steps to Reproduce (for bugs)

  1. Create a Column (experimental) block
  2. Hover your mouse underneath the paragraph block in either the left or right column

Expected Behavior

A grey line should appear on hover, indicating that clicking will insert a block at that position.

Current Behavior

No line appears. It does, however, correctly appear when you hover over the space in between blocks, just not when you hover over the space after the last block.

Screenshots / Video

bug

Related Issues and/or PRs

It's likely that #5541 introduced this regression.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Mar 21, 2018
@mtias
Copy link
Member

mtias commented Apr 5, 2018

The line appender is there to create an empty paragraph, since we are already on an empty paragraph, that's the expected result. Can you check what happens if the last item in the column is an image?

@mtias mtias closed this as completed Apr 5, 2018
@aduth
Copy link
Member

aduth commented Apr 5, 2018

Discussed in #core-editor weekly triage: https://wordpress.slack.com/archives/C02QB2JS7/p1522944366000137

@noisysocks
Copy link
Member Author

noisysocks commented Apr 5, 2018

It looks like the line no longer appears after the last block in the main editor now, which means that the behaviour is consistent 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants