-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming UI doesn't work for some blocks #57954
Comments
@getdave as a heads up based on your work here. Adding this to 6.5. |
@t-hamano Thank you for spotting these and following up. |
Does this already work with custom blocks? I added
To my custom block.json within the block.json support object
to my block.json attributes object but no rename field shows up. Only when i add :
to my block.json i see the name field when selecting my block, but the name doesn't appear in the list view Thank you |
@merijnponzo Could you please post information about how you are testing this? For example is the Gutenberg Plugin enable (version) and which version of WP. Many thanks |
@getdave sorry i can confirm this works with 6.5 without using:
and only
I am not sure if i still have to add:
To my block.json Great work! |
By default all blocks have renaming support so you shouldn't need to do anything. Please see #54426 (comment). |
For a custom block, I was using just Update Same code does work in 6.5 RC1… guess I just gotta wait a little bit. |
Rename support varies by WordPress version.
|
What problem does this address?
Renaming UI is now available for almost all blocks. However, in some blocks where
__experimentalLabel
is opted in, I found that the label entered in this UI is not reflected in the list view.For example, a paragraph block returns a custom label if the context is
list-view
.gutenberg/packages/block-library/src/paragraph/index.js
Lines 33 to 35 in 8b5bc0e
On the other hand, in the Image block, there is no process to return a custom label in the case of
list-view
context.What is your proposed solution?
We need to resolve this issue in blocks that have opted in to
__experimentalLabel
and wheresupports.renaming
is notfalse
inblock.json.
As far as I've researched, the problem needs to be resolved in the following blocks:
On the other hand, we shouldn't need to do anything with the following blocks.
The text was updated successfully, but these errors were encountered: