Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text styling bleeding into placeholder states #58151

Closed
richtabor opened this issue Jan 23, 2024 · 3 comments · Fixed by #58303
Closed

Text styling bleeding into placeholder states #58151

richtabor opened this issue Jan 23, 2024 · 3 comments · Fixed by #58303
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

I noticed today that the text stying is being applied inappropriately to the placeholder states. I would expect that no text styles should bleed into the editor UI. Even text-transform is being applied (tested via #58142).

Area.mp4
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jan 23, 2024
@richtabor richtabor moved this to ❓ Triage in WordPress 6.5 Editor Tasks Jan 23, 2024
@richtabor richtabor moved this to Needs development in Polish Jan 23, 2024
@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Jan 26, 2024

I was thinking about this, and there are two ways I see to solve this: we either reset the CSS of the placeholder component (and we will have to do this again for every global style control that we introduce in the future that may affect the component) or we make the Global Styles CSS to target everything but the components, which is also very tricky to do, since what's affecting this is the rules we set into body{} directly. I'm not sure which I like the best of the two, to be honest...

@carolinan
Copy link
Contributor

I am not sure if it is even related but the border radius on the image block is bleeding into the placeholder too. I did not discover it until yesterday but it also happens on 6.4 without Gutenberg active. Not on 6.2 or 6.3.

@MaggieCabrera
Copy link
Contributor

I am not sure if it is even related but the border radius on the image block is bleeding into the placeholder too. I did not discover it until yesterday but it also happens on 6.4 without Gutenberg active. Not on 6.2 or 6.3.

It must be for different reasons, in this case, when we style the text "element" what we are adding is CSS into the body tag, which then bleeds. The image block styles are targeting something different. Do you have an issue for that?

@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.5 Editor Tasks Jan 26, 2024
@github-project-automation github-project-automation bot moved this from Needs development to Done in Polish Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants