Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] Should not fail after save/reload #58217

Closed
github-actions bot opened this issue Jan 24, 2024 · 1 comment
Closed

[Flaky Test] Should not fail after save/reload #58217

github-actions bot opened this issue Jan 24, 2024 · 1 comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

Should not fail after save/reload

Test path

/test/e2e/specs/editor/blocks/classic.spec.js

Errors

[2024-01-24T19:23:50.811Z] Test passed after 1 failed attempt on trunk.
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Jan 24, 2024
github-actions bot referenced this issue Jan 24, 2024
#58085)

* Add actions and selectors to register new sources

* Add hook to read the bindings attribute in Edit

* Add context to all the blocks with bindings

* Lock rich text when `isContentBound` is true

* Adapt paragraph and heading blocks UI

* Adapt button block UI

* Adapt image block UI

* Register post meta source

* Don't use placeholder if attribute is `src` or `href`

* Always share placeholder in case meta is empty

* Remove `keyToLabel` and use just label

* Remove source component until it is needed

* Use translations in the source label

* Move `select` inside `useSource`

* Read `lockEditorUI` prop and add it for patterns

* Move logic to lock editing directly to RichText

* Improve `useSelect` destructuring

* Load all image controls if attributes are bound

* Remove unnecessary condition

* Move `lockAttributesEditing` to source definition

* Move `useSelect` into existing hook

* Fix `RichText` not being selected on click

* Lock button and image controls only when selected

* Remove unnecesarry optional chaining

* Move `shouldDisableEditing` logic inside callback

* Fix formatting issue
Copy link
Author

github-actions bot commented Feb 9, 2024

This issue has gone 15 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Feb 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

No branches or pull requests

0 participants