Font Library modal: Tab title is repeated in content

[mikachan]

What problem does this address?

In the Font Library modal, the tab title is displayed in both the tab and the contents of the tab:

What is your proposed solution?

We should consider removing the title inside the tab contents to reduce the repetition.

[colorful-tones]

Without looking at the code - we should consider screen readers and tab order here for accessibility. At the very least, we'll need aria-labelledby and aria-label to associate the tab with the tab-panel content, and the focus should likely shift to the first focusable item once a tab is selected.

In other words, the duplication of the text may be ideal, or if it is not, then we could hide it with CSS (.sr-only), but we want to make sure we do any of the above with accessibility at the forefront.

[mikachan]

Thanks @colorful-tones! I agree, and this issue was opened with accessibility in mind.

[akasunil]

Hi @mikachan
Is this issue still relevant? Design has been updated of font library. Here is latest screenshot

[mikachan]

Oh true, thanks @akasunil! I think we can close this then 🎉