Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Improve consistency of metrics and layout in headers #58293

Open
t-hamano opened this issue Jan 26, 2024 · 0 comments · May be fixed by #60729
Open

Tracking: Improve consistency of metrics and layout in headers #58293

t-hamano opened this issue Jan 26, 2024 · 0 comments · May be fixed by #60729
Assignees
Labels
[Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jan 26, 2024

This issue aims to improve consistency in header layout, metrics, etc. across all block editor instances. As far as I've researched, I think the following improvements and bug fixes are needed.

Related PRs:


Improvements

⚒️ Change header height from 60px to 64px

Target: Post Editor, Widget Editor, Site Editor

Also mentioned in this comment

image


Fixed

✅ Focus ring cut off

Target: Post Editor

We'll probably need a 2px margin on the left, like in the Site Editor.

image

✅ Standardize button size to 32px

Target: Post Editor, Widget Editor, Site Editor

Some buttons remain at 36px. Regarding the Widget Editor, note that we cannot refactor it with the DocumentTools component of the @wordpress/editor package. Please refer to #57660 for details.

Post Editor:

post-editor-button-size

Widget Editor:

widget-editor-button-size

✅ Overflow occurs

Target: Widget Editor

image

✅ Border misalignment when Show "button text labels" is enabled

When the mover button is horizontal, the border should be vertical.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Post /packages/edit-post [Package] Edit Site /packages/edit-site [Package] Edit Widgets /packages/edit-widgets [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant