Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: URL input field insufficient focus style #58494

Closed
afercia opened this issue Jan 31, 2024 · 0 comments · Fixed by #58505
Closed

Image: URL input field insufficient focus style #58494

afercia opened this issue Jan 31, 2024 · 0 comments · Fixed by #58505
Assignees
Labels
[Block] Image Affects the Image Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented Jan 31, 2024

Description

The image link URL implementation has always been slighly inconsistent with the normal Link UI, which is not ideal, but at least provided some level of accessibility.

Starting from WordPress 6.4, the focus style of the input field has been changed and it is now less visible and also inconsistent with the default input fields focus style. Making the focus style less visible isn't an improvement. Rather, it's a regression.

Specifically, the CSS sets the input border width to 0 only for visual aesthetics reasons but that impacts the focus style. IN fact the focus style relies on the border being visible. It appears this change hasn'g ben tested with keyboard and accessibility wasn't taken into account.

Screenshot from WordPress 6.3:

The focus style and overall styling of the input field is inconsistent with the default input styling but at least the focus style is a thick blue visual outline:

6 3

Screenshot from WordPress 6.4:

The focus style is thinner and barely visible.

6 4

Screenshot from WordPress trunk and Gutenberg trunk:

Same on trunk. I'd also say the horizontal alignment of the input and placeholder text isn't nice as it used to be.

trunk

Cc @annezazu can we please make sure this gets fixed for WP 6.5? Thanks 🙏

Step-by-step reproduction instructions

  • Add an image block.
  • In the block toolbar, click the Link button.
  • Initial focus is set to the input field.
  • Observe the focus style is worse than in previous versions.
  • Observe the horizontal alignment of the placeholder text could be improved.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Regression Related to a regression in the latest release [Block] Image Affects the Image Block labels Jan 31, 2024
@afercia afercia self-assigned this Jan 31, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 31, 2024
@annezazu annezazu moved this to 🏗️ In Progress in WordPress 6.5 Editor Tasks Feb 1, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.5 Editor Tasks Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant