Style revisions: reconsider identical styles messaging and apply button behaviour

[ramonjd]

This issue flags some open questions raised in the following discussion:

• Global styles revisions: update text color contrast  #58340 (comment)

cc @jameskoster

Identical styles message

It's possible that revisions match styles currently loaded in the editor,, e.g., if folks are using theme style variations or resetting and saving a lot.

When a revision's styles matches those in the editor, no "Apply" button is shown and the following message is displayed "These styles are already applied to your site."

Possible alternatives:

• shorter copy
• show the Apply button as per normal (even though it won't have any visual effect)
• semiotic/iconography?

Apply button behaviour

Currently, a style revision's "Apply" button restores that revision into the editor, and closes the styles revisions panel.

2024-02-01.10.24.15.mp4

The functionality to restore a revision is required, however the UX is open to review.

Alternatives:

• Show a confirmation modal (Do you wish to restore this revision?) before closing style revisions panel
• ?

Related

• Tracking: Style Revision UX Improvements #55776

[jameskoster]

Just to unpack a little why this is confusing; the revisions are presented in a timeline format, so it follows that the top-most item in that timeline is the most recent/active state. It's unexpected to find the active state half-way down the timeline, and given the message is the same as the one found in the active style details that's what the UI suggests.

A different message may be adequate... "Matches current styles", or similar.