Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent "BackButton" in site editor #58692

Closed
richtabor opened this issue Feb 5, 2024 · 6 comments
Closed

Inconsistent "BackButton" in site editor #58692

richtabor opened this issue Feb 5, 2024 · 6 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

We have two different "Back" buttons in the site editor; let's consolidate these into one consistent UI. I suspect that during some of the unification work the "Back" button was introduced in the canvas area. Instead we should rely on the existing "Back" button within the DocumentBar.

Current

As-is, the "Back" button in the top left of the UI does the same exact action as selecting the WP icon at the top left. It's not ideal having two actions do the same thing right next to each other—one of which is not anchored really (the "Back" button).

CleanShot 2024-02-05 at 14 33 22

Expected

CleanShot 2024-02-05 at 14 32 58

I propose we utilize the "Back" button within the DocumentBar.

We can circle back and tidy up the design itself, but it is an established flow to navigate "up" one level, out of template editing (to the page), that we could also use to navigate "up" one level, out of pattern editing (to the site editor patterns).

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 5, 2024
@annezazu
Copy link
Contributor

annezazu commented Feb 5, 2024

This seems to overlap with a number of issues -- which can we close?

#56868
#54628
#50106

@richtabor
Copy link
Member Author

They're all related, but slightly different angles. I see those are exploratory whereas this is an actionable fix that we need, regardless of the outcomes of those particular ideas.

@richtabor
Copy link
Member Author

@youknowriad do you think this made it in from the recent unification work?

@richtabor
Copy link
Member Author

Noting that when this is resolved, we can move forward with #57124

@youknowriad
Copy link
Contributor

I think this has been solved already by @noisysocks

@noisysocks
Copy link
Member

Yes fixed by #58528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants