-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify visual separator between mover buttons when show button label is on #58999
Comments
Is a visual separator still necessary when mover buttons are horizontally aligned? I would appreciate any advice from an accessibility perspective 🙏 |
Ouch I missed these buttons change to 'Move left' and 'Move right' for blocks that can be rearranged horizontally 🤦🏽
Generally, from an a11y perspective, I don't like buttons with no borders. Ideally, all buttons should have borders, which would make separators pointless. I'd say that for now we should make them look consistently with other buttons groups where separators are only used between groups while buttons don't have separators. For example in a Heading block: The format buttons don't have separators becouse they belong to the same group. Aside: I don't understand why 'Change level' and 'Align text' are in the same group. Their purpose and functionality is different and they shouldn't be in the same group. I see they are in the same group also with icon buttons... |
Thank you for your reply. In that case, do you think the following is the best solution at this point?
|
Yes I think for now that's the best path forward 👍🏽 |
Description
As mentioned in #49556, there should be a visual separator between mover buttons when "show button label" is on. However, depending on the browser size, block orientation, and whether the top toolbar is enabled, this separator may not display correctly.
Desktop view and horizontal layout
Desktop view, horizontal layout, and top toolbar enabled
Tablet view
Tablet view and horizontal layout
Mobile view
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
Regarding this issue, #49556 and #57640 are related, but not all issues were introduced in WP6.5. It may not be a necessary task for WP6.5, but if we can fix it, I think it's worth backporting.
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: