Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Hooks: Toggle to enable/disable hooked block doesn't work properly #59001

Closed
pkuliga opened this issue Feb 14, 2024 · 1 comment · Fixed by #59367
Closed

Block Hooks: Toggle to enable/disable hooked block doesn't work properly #59001

pkuliga opened this issue Feb 14, 2024 · 1 comment · Fixed by #59367
Assignees
@ockham @tjcafferkey
Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@pkuliga
Copy link

pkuliga commented Feb 14, 2024

Description

The hooked block should be hidden when the toggle is clicked but it's duplicated instead.

Step-by-step reproduction instructions

  1. Hook a block to the last child of the Navigation block by using a block.json file
  2. Go to Site Editor and edit the Single template
  3. Click on the Navigation block and open the block Settings
  4. Click the toggle to enable/disable the hooked block

Screenshots, screen recording, code snippet

2024-02-13 10 12 21

Environment info

  • WordPress 6.5-beta1-57631
  • Gutenberg 17.7.0-rc.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No
@pkuliga pkuliga added the [Type] Bug An existing feature does not function as intended label Feb 14, 2024
@ockham ockham added the [Feature] Block API API that allows to express the block paradigm. label Feb 14, 2024
@ockham
Copy link
Contributor

ockham commented Feb 22, 2024

WIP PR to fix this: #59277

@tjcafferkey tjcafferkey mentioned this issue Feb 23, 2024
Closed
This was referenced Feb 26, 2024
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ockham ockham

@tjcafferkey tjcafferkey

Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
3 participants
@ockham @pkuliga @tjcafferkey