-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data views: Make the links look like links #59176
Comments
This is even more true in the 'Grid' view, where the item title really looks like the checkbox label. See screenshot below. |
Question: why the title is a link in the Pages cards and instead it's a button in the Patterns cards? Pages: gutenberg/packages/edit-site/src/components/page-pages/index.js Lines 295 to 302 in e1cd130
Patterns: it's a button element with 'link' variant but it usss gutenberg/packages/edit-site/src/components/page-patterns/index.js Lines 199 to 204 in e1cd130
We need to make the UI consistent not only visually, but also semantically and in terms of expected interaction. |
Regarding the Grid cards, I think the current design is confusing and less than ideal both visually, semantically, and as expected interaction. Thinking it needs to be refined, made more consistent, and predictable.
I'd like to propose to make things work as expected based on their visual appearance. More importantly, Selection and editing controls should be clearly separated.
|
These descriptions and tooltips on the author and status need to be removed. As discussed in another issue, ariakit makes an incorrect usage of tooltips by making any element a description is attached to a focusable element. This makes some div elements focusable, whith is far from ideal. Tooltips should not be used for descriptions on non-interactive elements. |
I updated the test instructions to make it clearer to switch to the 'Table' or "Grid' layout to test. |
Description
See related #59175
In the data views, the title of each item is actually a link to the item details. For example in the case of the Pages list the page title is a link to the page editing view.
However, the title text is a gray text. It looks like normal, non-interactive, text. There is no visual indication that it's a link.
Moreover, when hovering a row, the title text looks like the checkbox label. As a user, I would expect that clicking that text selects the checkbox.
An inclusive user interface needs to be predictable and self-explanatory. Links must look like links.
Step-by-step reproduction instructions
Go to Site editor > Pages > Manage all pages.Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: