DataForm component

[youknowriad]

Related:

• Admin redesign: Settings #63624
• Data views: quick-editing #55101
• DataViews component #55083

Problem scope

As we continue expanding our UIs, be it the editor UI or new pages being added to the site editor, we’re finding our selves creating a lot of forms to edit entities and for each one of these, we keep recreating adhoc designs and implement adhoc forms.

Here are some of the existing forms:

Where	Screenshot
The inspector panel for post/pages/templates/patterns
Forms to create new patterns/pages/templates
Details panels

Also, as we advance into the admin redesign work, we’ll be creating even more forms:

• creating and editing media (media quick edit) for the Media Library project
• creating and updating categories
• quick edit for the dataviews
• bulk editing for the dataviews

To avoid creating and designing UIs for these over and over again in an ad-hoc and inconsistent way, we should explore an API to generate these forms consistently.

Proposal

When implementing the DataViews in the site editor, we introduce a “fields” config for each data view component. To render a DataView, we’ve built a generic component with the following API:

<DataViews data={data} fields={ fields } view={ view } />

So this component render a list of items given a “fields” config and a some options (view).

Similarly, we should explore building a generic component that renders a form/panel

<DataForm item={item} fields={ fields } form={ form } />

Such component would render a form or panel for a given item based on a “fields” config and some options (form).

Notes

• It would be good to share the same “fields” config as the one used in the dataviews project, I think this might force us to formalize the field “types” more.
• Having a reusable component like that will also allow us to provide a consistent extensibility API ultimately.
• A library like that could be a good inspiration https://github.com/pmndrs/leva
• Let’s try to explore this as a prototype, for instance let’s have an initial goal of building a quick edit form for posts (basically recreate the inspector panel for posts) and try to discover what kind of config we need there.

Tasks

• DataForm: implement first prototype using duplicate page action #63032
• DataViews: Bootstrap Quick Edit #63600
• DataForm: Add a simple story for the DataForm component #63840
• DataForm: migrate order action modal and introduce form validation #63895
• DataForm: add author to quick edit page/post list #63983
• DataForm: move validation logic to the field type definition #64164
• DataViews: formalize text field type definition #64168
• DataForm: replicate DocumentInspector in QuickEdit #64519
• DataForm: make it work nicely with bulk editing #65685
• Data Views: Implement selectItem callback #66338
• Layout flexibility DataForm: enable fields to declare a different layout #66531
• Extensibility API - Assess how a plugin can register its field (or field type) using dedicated APIs.
• Sync edits
  • When user edit the title in the editor and then visit Pages, both the DataViews and QuickEdit should have the new title.
  • When users edit the title via QuickEdit, DataViews should reflect the new title immediately. If the users visit the Editor at that point, they should also see the new title.

Improvements

• DataForm: Consolidate render function argument #66616
• DataForm: Improve loading state management #66599
• Data Form: define props to differentiate field layouts #66336

Fields improvements

• Featured Image Field: Improve layout #66332
• Implement validation to the Slug field QuickEdit: Add slug field control #65196 (comment)

[joshuatf]

@youknowriad @oandregal Out of curiosity, will the DataForm ever allow control over layout within a form (columns, tabs, sections, etc) or would those be comprised of multiple DataForms?

[youknowriad]

@joshuatf My current thinking is that "columns" and "tabs" are something you should be able to control on the form object. It's not clear to me at this point if a single "form type" can absorb everything or if we'd need several "form layouts" or "form types" like we have for data views, but I think we should be able do say, I want to group these fields in a tab...

[jameskoster]

Noting this is closely related to #63624.

[oandregal]

Added a new section in the issue for "Task/Log".

Also: created #63895 that prepares the initial structure for validation.

[oandregal]

#63983 adds the ability to update the author in the quick edit form.

[oandregal]

In #63983 I ran into some issues with sorting. While working on them we discussed the need to formalize a bit the existing field types. This is the ongoing work:

• DataViews: sort author by name + allow custom sort function #64064
• DataForm: move validation logic to the field type definition #64164
• DataViews: formalize text field type definition #64168
• DataForm: centralize edit logic in field type definitions #64171

[oandregal]

Edited a bit the issue description, including updating the issue title to DataForm component, like we have the DataViews component.

Also added some new tasks:

• DataForm: make it work nicely with bulk editing #65685
• Sync edits
  • When user edit the title in the editor and then visit Pages, both the DataViews and QuickEdit should have the new title.
  • When users edit the title via QuickEdit, DataViews should reflect the new title immediately. If the users visit the Editor at that point, they should also see the new title.

[gigitux]

Edited a bit the issue description, adding some issues that we opened in the last weeks. I hope that it is fine!

cc @youknowriad @oandregal @louwie17