Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Pullquote Block for adding Style color option for citation also #59941

Closed
pitamdey opened this issue Mar 18, 2024 · 2 comments
Closed
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@pitamdey
Copy link

What problem does this address?

This is just a request for enhancement in the Pullquote block, Currently, we can change the colour of quotes but not the colour of the citation

What is your proposed solution?

we can add separate colour option for citations also if possible

@pitamdey pitamdey added the [Type] Enhancement A suggestion for improvement. label Mar 18, 2024
@aaronrobertshaw
Copy link
Contributor

Hi @pitamdey 👋

Just to clarify, your proposal is to allow different colors for the quote vs citation?

That would likely require refactoring the pullquote block to use inner blocks for the cite element. This is somewhat similar to past proposals to make captions inner blocks for image-related blocks. Unfortunately, there hasn't been a lot desire for such features to push them forwards.

we can change the colour of quotes but not the colour of the citation

My understanding is that you can change the color of the Pullquote block's citation.

Screenshot 2024-03-18 at 5 26 38 PM

@pitamdey
Copy link
Author

Thanks @aaronrobertshaw, I think this one is theme related issue so i will check it and report it to the core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants