Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep an inserted pattern within view when added to the page #59962

Closed
Tracked by #50739
richtabor opened this issue Mar 18, 2024 · 2 comments
Closed
Tracked by #50739

Keep an inserted pattern within view when added to the page #59962

richtabor opened this issue Mar 18, 2024 · 2 comments
Assignees
@akasunil
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Mar 18, 2024 •
edited
Loading

Currently, selecting a pattern from the Inserter results in the pattern added to the bottom of the page, but does not give you any real indication that it has been successfully added—other than a snackbar notification. Each pattern is already focused when inserted, but if it's not one of the first patterns on a page, you wouldn't see where it's applied/focused.

I propose that when adding patterns to a page, the pattern should be within view.

This way:

  • I don't have to scroll down to find the pattern added to my page.
  • I have immediate confidence that my selection occurred (rather than relying solely on a snackbar).
  • I can quickly take the next steps, whether that means to move it, shuffle it to another pattern, or delete it.

Current

insertion-flow.mp4
@richtabor richtabor mentioned this issue Mar 18, 2024
Open
42 tasks
@richtabor richtabor changed the title Keep an inserted pattern within view when it is added to the page from the Inserter Keep an inserted pattern within view when inserted Mar 18, 2024
@richtabor richtabor changed the title Keep an inserted pattern within view when inserted Keep an inserted block/pattern within view when inserted Mar 18, 2024
@richtabor richtabor changed the title Keep an inserted block/pattern within view when inserted Keep an inserted pattern within view when inserted Mar 18, 2024
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out labels Mar 18, 2024
@richtabor richtabor changed the title Keep an inserted pattern within view when inserted Keep an inserted pattern within view when selected Mar 18, 2024
@richtabor richtabor changed the title Keep an inserted pattern within view when selected Keep an inserted pattern within view when added to the page Mar 21, 2024
@akasunil akasunil mentioned this issue Jun 20, 2024
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 20, 2024
@akasunil
Copy link
Member

@richtabor Created PR #62700 to resolve this issue.

@akasunil
Copy link
Member

I guess we can close this issue too as it fixes in latest trunk as show in video here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akasunil akasunil

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep an inserted pattern within view when added to the page WordPress/gutenberg
2 participants
@richtabor @akasunil